fix: remove list item placement animation due to occasional visual gl…

…itch closes #1038
lydavid · Aug 22, 2024 · 0ab917f · 0ab917f
1 parent e060361
commit 0ab917f
Show file tree

Hide file tree

Showing 16 changed files with 0 additions and 23 deletions.
diff --git a/...main/java/ly/david/musicsearch/android/feature/nowplaying/internal/NowPlayingHistoryUi.kt b/...main/java/ly/david/musicsearch/android/feature/nowplaying/internal/NowPlayingHistoryUi.kt
@@ -122,7 +122,6 @@ private fun NowPlayingHistoryContent(
                     content = {
                         NowPlayingHistoryCard(
                             nowPlayingHistory = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                             onClick = {
                                 searchMusicBrainz(
                                     "\"$title\" artist:\"$artist\"",

diff --git a/...fy/src/main/java/ly/david/musicsearch/android/feature/spotify/history/SpotifyHistoryUi.kt b/...fy/src/main/java/ly/david/musicsearch/android/feature/spotify/history/SpotifyHistoryUi.kt
@@ -199,7 +199,6 @@ private fun SpotifyHistoryContent(
                     content = {
                         SpotifyHistoryCard(
                             spotifyHistory = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                             onClick = {
                                 clickListItem = this
                             },

diff --git a/...y/david/musicsearch/shared/feature/collections/components/CollectionBottomSheetContent.kt b/...y/david/musicsearch/shared/feature/collections/components/CollectionBottomSheetContent.kt
@@ -64,7 +64,6 @@ internal fun ColumnScope.CollectionBottomSheetContent(
                 is CollectionListItemModel -> {
                     CollectionListItem(
                         collection = collection,
-                        modifier = Modifier.animateItemPlacement(),
                         onClick = {
                             onAddToCollection(collection.id)
                         },

diff --git a/...ommonMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/CollectionListUi.kt b/...ommonMain/kotlin/ly/david/musicsearch/shared/feature/collections/list/CollectionListUi.kt
@@ -173,8 +173,6 @@ internal fun CollectionListUi(
                 is CollectionListItemModel -> {
                     CollectionListItem(
                         collection = collectionListItemModel,
-                        // TODO: animateItemPlacement messes up UI in emulator
-//                        modifier = Modifier.animateItemPlacement(),
                         onClick = { onCollectionClick(id) },
                     )
                 }

diff --git a/.../commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt b/.../commonMain/kotlin/ly/david/musicsearch/shared/feature/collections/single/CollectionUi.kt
@@ -405,7 +405,6 @@ internal fun CollectionUi(
                     content = {
                         AreaListItem(
                             area = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onItemClick(
                                 entity,
@@ -428,7 +427,6 @@ internal fun CollectionUi(
                     content = {
                         InstrumentListItem(
                             instrument = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onItemClick(
                                 entity,
@@ -451,7 +449,6 @@ internal fun CollectionUi(
                     content = {
                         PlaceListItem(
                             place = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onItemClick(
                                 entity,
@@ -474,7 +471,6 @@ internal fun CollectionUi(
                     content = {
                         RecordingListItem(
                             recording = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onItemClick(
                                 entity,
@@ -497,7 +493,6 @@ internal fun CollectionUi(
                     content = {
                         SeriesListItem(
                             series = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onItemClick(
                                 entity,

diff --git a/...nMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseScreen.kt b/...nMain/kotlin/ly/david/musicsearch/shared/feature/details/release/TracksByReleaseScreen.kt
@@ -39,7 +39,6 @@ internal fun TracksByReleaseScreen(
             is TrackListItemModel -> {
                 TrackListItem(
                     track = listItemModel,
-                    modifier = Modifier.animateItemPlacement(),
                     onRecordingClick = onRecordingClick,
                 )
             }

diff --git a/...y/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/history/internal/HistoryUi.kt b/...y/src/commonMain/kotlin/ly/david/musicsearch/shared/feature/history/internal/HistoryUi.kt
@@ -197,7 +197,6 @@ internal fun HistoryUi(
             is LookupHistoryListItemModel -> {
                 HistoryListItem(
                     lookupHistory = listItemModel,
-                    modifier = Modifier.animateItemPlacement(),
                     onItemClick = onItemClick,
                     onDeleteItem = onDeleteItem,
                 )

diff --git a/...monMain/kotlin/ly/david/musicsearch/shared/feature/search/internal/SearchHistoryScreen.kt b/...monMain/kotlin/ly/david/musicsearch/shared/feature/search/internal/SearchHistoryScreen.kt
@@ -8,7 +8,6 @@ import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
-import androidx.compose.ui.Modifier
 import app.cash.paging.compose.LazyPagingItems
 import ly.david.musicsearch.shared.domain.listitem.Header
 import ly.david.musicsearch.shared.domain.listitem.ListItemModel
@@ -18,7 +17,6 @@ import ly.david.musicsearch.ui.core.LocalStrings
 import ly.david.musicsearch.ui.common.dialog.SimpleAlertDialog
 import ly.david.musicsearch.ui.common.paging.ScreenWithPagingLoadingAndError
 
-@OptIn(ExperimentalFoundationApi::class)
 @Composable
 internal fun SearchHistoryScreen(
     lazyPagingItems: LazyPagingItems<ListItemModel>,
@@ -57,7 +55,6 @@ internal fun SearchHistoryScreen(
             is SearchHistoryListItemModel -> {
                 SearchHistoryListItem(
                     searchHistory = listItemModel,
-                    modifier = Modifier.animateItemPlacement(),
                     onItemClick = onItemClick,
                     onDeleteItem = onDeleteItem,
                 )

diff --git a/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistsListScreen.kt b/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/artist/ArtistsListScreen.kt
@@ -34,7 +34,6 @@ fun ArtistsListScreen(
                     content = {
                         ArtistListItem(
                             artist = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onItemClick(
                                 MusicBrainzEntity.ARTIST,

diff --git a/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventsListScreen.kt b/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/event/EventsListScreen.kt
@@ -34,7 +34,6 @@ fun EventsListScreen(
                     content = {
                         EventListItem(
                             event = eventListItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onEventClick(
                                 MusicBrainzEntity.EVENT,

diff --git a/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/label/LabelsListScreen.kt b/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/label/LabelsListScreen.kt
@@ -35,7 +35,6 @@ fun LabelsListScreen(
                     content = {
                         LabelListItem(
                             label = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onLabelClick(
                                 MusicBrainzEntity.LABEL,

diff --git a/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/place/PlacesListScreen.kt b/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/place/PlacesListScreen.kt
@@ -30,7 +30,6 @@ fun PlacesListScreen(
             is PlaceListItemModel -> {
                 PlaceListItem(
                     place = placeListItemModel,
-                    modifier = Modifier.animateItemPlacement(),
                 ) {
                     onPlaceClick(
                         MusicBrainzEntity.PLACE,

diff --git a/...on/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingsListScreen.kt b/...on/src/commonMain/kotlin/ly/david/musicsearch/ui/common/recording/RecordingsListScreen.kt
@@ -31,7 +31,6 @@ fun RecordingsListScreen(
             is RecordingListItemModel -> {
                 RecordingListItem(
                     recording = recordingListItemModel,
-                    modifier = Modifier.animateItemPlacement(),
                 ) {
                     onRecordingClick(
                         MusicBrainzEntity.RECORDING,

diff --git a/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleasesListScreen.kt b/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/release/ReleasesListScreen.kt
@@ -37,7 +37,6 @@ fun ReleasesListScreen(
                     content = {
                         ReleaseListItem(
                             release = releaseListItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                             showMoreInfo = showMoreInfo,
                             requestForMissingCoverArtUrl = {
                                 requestForMissingCoverArtUrl(releaseListItemModel.id)

diff --git a/.../commonMain/kotlin/ly/david/musicsearch/ui/common/releasegroup/ReleaseGroupsListScreen.kt b/.../commonMain/kotlin/ly/david/musicsearch/ui/common/releasegroup/ReleaseGroupsListScreen.kt
@@ -40,7 +40,6 @@ fun ReleaseGroupsListScreen(
                         ReleaseGroupListItem(
                             releaseGroup = listItemModel,
                             showType = false,
-                            modifier = Modifier.animateItemPlacement(),
                             requestForMissingCoverArtUrl = {
                                 requestForMissingCoverArtUrl(listItemModel.id)
                             },

diff --git a/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorksListScreen.kt b/ui/common/src/commonMain/kotlin/ly/david/musicsearch/ui/common/work/WorksListScreen.kt
@@ -35,7 +35,6 @@ fun WorksListScreen(
                     content = {
                         WorkListItem(
                             work = listItemModel,
-                            modifier = Modifier.animateItemPlacement(),
                         ) {
                             onWorkClick(
                                 MusicBrainzEntity.WORK,