Revert "Revert "Revert "Revert "remove skips""""

This reverts commit d97fbb5.
lyft · May 5, 2023 · fb202d4 · fb202d4
1 parent bcb53bc
commit fb202d4
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 18 deletions.
diff --git a/integ/blue_green_deployment_test.go b/integ/blue_green_deployment_test.go
@@ -10,8 +10,6 @@ import (
 )
 
 func WaitForUpdate(c *C, s *IntegSuite, name string, updateFn func(app *v1beta1.FlinkApplication), phase v1beta1.FlinkApplicationPhase, failurePhase v1beta1.FlinkApplicationPhase) *v1beta1.FlinkApplication {
-	c.Skip("local")
-
 	// update with new image.
 	app, err := s.Util.Update(name, updateFn)
 	c.Assert(err, IsNil)
@@ -34,8 +32,6 @@ func WaitForUpdate(c *C, s *IntegSuite, name string, updateFn func(app *v1beta1.
 }
 
 func (s *IntegSuite) TestUpdateWithBlueGreenDeploymentMode(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestUpdateWithBlueGreenDeploymentMode")
 
 	testName := "bluegreenupdate"

diff --git a/integ/checkpoint_failure_test.go b/integ/checkpoint_failure_test.go
@@ -66,8 +66,6 @@ func failingJobTest(s *IntegSuite, c *C, testName string, causeFailure func()) {
 
 // Tests that we correctly handle updating a job with a checkpoint timeout
 func (s *IntegSuite) TestCheckpointTimeout(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestCheckpointTimeout")
 
 	failingJobTest(s, c, "checkpointtimeout", func() {
@@ -162,7 +160,6 @@ func failingTaskTest(s *IntegSuite, c *C, testName string, fallbackWithoutState
 
 // Tests that we correctly handle updating a job with task failures
 func (s *IntegSuite) TestJobWithTaskFailures(c *C) {
-
 	log.Info("Starting test TestJobWithTaskFailures")
 	failingTaskTest(s, c, "taskfailure", false, true, func() {
 		err := s.Util.ExecuteCommand("minikube", "ssh", "touch /tmp/checkpoints/fail && chmod 0644 /tmp/checkpoints/fail")
@@ -176,7 +173,6 @@ func (s *IntegSuite) TestJobWithTaskFailures(c *C) {
 }
 
 func (s *IntegSuite) TestSavepointCheckpointFailureFallback(c *C) {
-
 	log.Info("Starting test TestSavepointCheckpointFailureFallback")
 	failingTaskTest(s, c, "recoveryfallback", true, false, func() {
 		err := s.Util.ExecuteCommand("minikube", "ssh", "touch /tmp/checkpoints/fail && chmod 0644 /tmp/checkpoints/fail")

diff --git a/integ/job_cancellation_test.go b/integ/job_cancellation_test.go
@@ -58,8 +58,6 @@ func WaitUpdateAndValidate(c *C, s *IntegSuite, name string, updateFn func(app *
 
 // tests the workflow of job cancellation without savepoint
 func (s *IntegSuite) TestJobCancellationWithoutSavepoint(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestJobCancellationWithoutSavepoint")
 	testName := "cancelsuccess"
 	const finalizer = "simple.finalizers.test.com"
@@ -139,8 +137,6 @@ func (s *IntegSuite) TestJobCancellationWithoutSavepoint(c *C) {
 // tests a job update with the existing job already in cancelled state.
 // here, the new submitted job starts without a savepoint.
 func (s *IntegSuite) TestCancelledJobWithoutSavepoint(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestCancelledJobWithoutSavepoint")
 
 	testName := "invalidcancel"
@@ -217,8 +213,6 @@ func (s *IntegSuite) TestCancelledJobWithoutSavepoint(c *C) {
 
 // tests the recovery workflow of the job when savepoint is disabled.
 func (s *IntegSuite) TestJobRecoveryWithoutSavepoint(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestJobRecoveryWithoutSavepoint")
 
 	const finalizer = "simple.finalizers.test.com"

diff --git a/integ/simple_test.go b/integ/simple_test.go
@@ -68,8 +68,6 @@ func updateAndValidate(c *C, s *IntegSuite, name string, updateFn func(app *v1be
 
 // Tests job submission, upgrade, rollback, and deletion
 func (s *IntegSuite) TestSimple(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestSimple")
 
 	const finalizer = "simple.finalizers.test.com"
@@ -268,8 +266,6 @@ func (s *IntegSuite) TestSimple(c *C) {
 }
 
 func (s *IntegSuite) TestRecovery(c *C) {
-	c.Skip("local")
-
 	log.Info("Starting test TestRecovery")
 
 	config, err := s.Util.ReadFlinkApplication("test_app.yaml")