Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Test go upgrade and go mod upgrade #281

Draft
wants to merge 81 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
ec41103
go modules
danielmmetz Mar 13, 2023
2e20580
omg it passes tests
danielmmetz Mar 13, 2023
84481bc
add this back
danielmmetz Mar 13, 2023
959bb44
drop install
danielmmetz Mar 13, 2023
d24f1bd
quote
danielmmetz Mar 13, 2023
6f9078c
fix lint
danielmmetz Mar 13, 2023
b7d1509
try this
danielmmetz Mar 13, 2023
5f28d83
just keep swimming
danielmmetz Mar 13, 2023
a0a90a0
local test working for TestJobCancellationWithoutSavepoint
sethsaperstein-lyft Mar 21, 2023
0cc931c
comment back in tests
sethsaperstein-lyft Mar 21, 2023
3859dc3
waits between cancel
sethsaperstein-lyft Mar 22, 2023
33234ca
5 min timeout
sethsaperstein-lyft Mar 22, 2023
a43addf
additional logging
sethsaperstein-lyft Mar 22, 2023
698bc34
remove local debug changes
sethsaperstein-lyft Mar 22, 2023
4e81a8d
test app on flink 1.11
sethsaperstein-lyft Mar 23, 2023
cb21077
remove local changes
sethsaperstein-lyft Mar 23, 2023
8a7811b
fix docker location
sethsaperstein-lyft Mar 23, 2023
68b2330
move to proper dir
sethsaperstein-lyft Mar 23, 2023
b0eede8
break waiting after 30s so errors show
sethsaperstein-lyft Mar 23, 2023
490f385
log all events at failure
sethsaperstein-lyft Mar 23, 2023
f821e91
forgot to add microk8s docker build and push
sethsaperstein-lyft Mar 23, 2023
3e6dbfe
wait longer for running app
sethsaperstein-lyft Mar 23, 2023
5101df2
tm logs first
sethsaperstein-lyft Mar 23, 2023
e904616
see if microk8s can take the memory
sethsaperstein-lyft Mar 23, 2023
0196be5
bump memory for tm due to 20mb allocated to task heap
sethsaperstein-lyft Mar 24, 2023
abc7186
increase flink tm heap size
sethsaperstein-lyft Mar 24, 2023
3965f45
set memory param. likely oom on second cluster
sethsaperstein-lyft Mar 24, 2023
74bebca
fix typo
sethsaperstein-lyft Mar 24, 2023
bca42b4
change memory configs
sethsaperstein-lyft Mar 24, 2023
02ebaef
add limits to containers. add concurrency limit to go test
sethsaperstein-lyft Mar 24, 2023
c469f10
limit cpu
sethsaperstein-lyft Mar 24, 2023
bd5a7b7
describe k8s resources on failure
sethsaperstein-lyft Mar 24, 2023
b3fabc6
add get pods to view restarts
sethsaperstein-lyft Mar 24, 2023
f425da7
try with minikube
sethsaperstein-lyft Mar 24, 2023
5350c37
flink 1.8 not 1.11
sethsaperstein-lyft Mar 24, 2023
3110b64
make executable
sethsaperstein-lyft Mar 24, 2023
f6cc040
remove microk8s from proxy kube
sethsaperstein-lyft Mar 24, 2023
15787c6
fix minikube command
sethsaperstein-lyft Mar 25, 2023
521bac5
disable rbac
sethsaperstein-lyft Mar 25, 2023
2c09fb2
workaround auth
sethsaperstein-lyft Mar 25, 2023
4cb11e5
fix file writing
sethsaperstein-lyft Mar 25, 2023
80b8251
raise timeout
sethsaperstein-lyft Mar 25, 2023
38d31d6
all integ tests passing local direct
sethsaperstein-lyft Mar 27, 2023
9ea26a8
bump minikube mem
sethsaperstein-lyft Mar 27, 2023
9a2f36b
decrease minikube mem
sethsaperstein-lyft Mar 27, 2023
6a8b657
removing permissions crashes minikube api
sethsaperstein-lyft Mar 27, 2023
f4bfd5b
add role
sethsaperstein-lyft Mar 27, 2023
f1d51ff
update timeouts
sethsaperstein-lyft Mar 27, 2023
532906d
raise timeout for cluster start. add tags to tests
sethsaperstein-lyft Mar 27, 2023
b5d6626
add better gc. add longer timeout
sethsaperstein-lyft Mar 27, 2023
eb7ede2
comment out scale up test as it uses too much cpu
sethsaperstein-lyft Mar 28, 2023
238f0ce
try to increase cpus. 2 should be max but lets find out
sethsaperstein-lyft Mar 28, 2023
cd0b4b1
yep 2 cpus in max
sethsaperstein-lyft Mar 28, 2023
5fc7c04
refactor clean up
sethsaperstein-lyft Mar 28, 2023
09b094d
update readme
sethsaperstein-lyft Mar 28, 2023
54c61af
update local dev docs
sethsaperstein-lyft Mar 28, 2023
13ac8c0
update ubuntu
sethsaperstein-lyft Mar 28, 2023
138b0a4
update ubuntu
sethsaperstein-lyft Mar 28, 2023
73a17cf
see if kube config directory issue is due to ubuntu upgrade
sethsaperstein-lyft Mar 29, 2023
b1dfd96
remove unused minikube command
sethsaperstein-lyft Mar 29, 2023
c928440
fix namespace in clusterrolebinding
sethsaperstein-lyft Mar 29, 2023
de9651f
fix lint issues
sethsaperstein-lyft Mar 29, 2023
1dd4788
move import for lint
sethsaperstein-lyft Mar 29, 2023
63b6797
upgrade ubuntu again
sethsaperstein-lyft Mar 29, 2023
1cbc3f6
attempt to fix ubuntu upgrade issue
sethsaperstein-lyft Mar 29, 2023
3db9f0c
after cluster start
sethsaperstein-lyft Mar 29, 2023
6e86f70
check if kube dir exists
sethsaperstein-lyft Mar 29, 2023
7fab7cc
set kube config location
sethsaperstein-lyft Mar 29, 2023
11fbbe8
check kube config env var
sethsaperstein-lyft Mar 30, 2023
69ccd27
move env var to test.sh since sudo
sethsaperstein-lyft Mar 30, 2023
21b7f7b
update docs
sethsaperstein-lyft Mar 30, 2023
2579200
upgrade newer ubuntu. all setup sudo so home is same
sethsaperstein-lyft Mar 30, 2023
48b2ecf
run tests without sudo
sethsaperstein-lyft Mar 30, 2023
aba457f
fix format
sethsaperstein-lyft Mar 30, 2023
db88cf9
remove commented env var
sethsaperstein-lyft Mar 30, 2023
f57ecbb
merge go upgrades to integ test fix
sethsaperstein-lyft Mar 30, 2023
9ceb4e3
fix merge conflict
sethsaperstein-lyft Mar 30, 2023
7fa8f9c
use go mod in integ test
sethsaperstein-lyft Mar 30, 2023
1eb98c6
update docs
sethsaperstein-lyft Mar 30, 2023
feede92
update go version for integ test
sethsaperstein-lyft Mar 30, 2023
29ff000
fix merge conflicts
sethsaperstein-lyft Mar 31, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ jobs:
- name: install go
uses: actions/setup-go@v2
with:
go-version: 1.12
- name: install
run: make install
go-version: "1.20"
- name: test
run: make test_unit
lint:
Expand All @@ -42,9 +40,7 @@ jobs:
- name: install go
uses: actions/setup-go@v2
with:
go-version: 1.12
- name: install
run: make install
go-version: "1.20"
- name: test
run: make lint
integration-tests:
Expand All @@ -63,7 +59,7 @@ jobs:
- name: install go
uses: actions/setup-go@v2
with:
go-version: 1.12
go-version: "1.20"
- name: install
run: integ/install.sh
- name: setup
Expand Down
14 changes: 5 additions & 9 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,28 +1,24 @@
FROM golang:1.13.4-alpine3.10 as builder
FROM golang:1.20.2-alpine3.17 as builder
RUN apk add git openssh-client make curl bash

COPY boilerplate/lyft/golang_test_targets/dep_install.sh /go/src/github.com/lyft/flinkk8soperator/

# COPY only the dep files for efficient caching
COPY Gopkg.* /go/src/github.com/lyft/flinkk8soperator/
COPY go.mod go.sum /go/src/github.com/lyft/flinkk8soperator/
WORKDIR /go/src/github.com/lyft/flinkk8soperator

# Pull dependencies
RUN : \
&& sh dep_install.sh \
&& dep ensure -vendor-only
RUN go mod download

# COPY the rest of the source code
COPY . /go/src/github.com/lyft/flinkk8soperator/

# This 'linux_compile' target should compile binaries to the /artifacts directory
# The main entrypoint should be compiled to /artifacts/flinkk8soperator
RUN make linux_compile
RUN go mod vendor && make linux_compile

# update the PATH to include the /artifacts directory
ENV PATH="/artifacts:${PATH}"

# This will eventually move to centurylink/ca-certs:latest for minimum possible image size
FROM alpine:3.10
FROM alpine:3.17
COPY --from=builder /artifacts /bin
CMD ["flinkoperator"]
Loading