Add @NoEscape to transformations

I'm not sure why this wasn't here before, we're obviously not holding on to these closures.
lyft · Jul 12, 2016 · b738e35 · b738e35
1 parent 72fb80e
commit b738e35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,7 +14,9 @@
 
 ## Enhancements
 
-- None
+- Add `@noescape` to transformation closures
+  [Keith Smiley](https://github.com/keith)
+  [#60](https://github.com/lyft/mapper/pull/60)
 
 ## Bug Fixes
 

diff --git a/Sources/Mapper.swift b/Sources/Mapper.swift
@@ -359,7 +359,7 @@ public struct Mapper {
      - returns: The value of type T for the given field
      */
     @warn_unused_result
-    public func from<T>(field: String, transformation: AnyObject? throws -> T) throws -> T {
+    public func from<T>(field: String, @noescape transformation: AnyObject? throws -> T) throws -> T {
         return try transformation(try self.JSONFromField(field))
     }
 
@@ -374,7 +374,7 @@ public struct Mapper {
                 otherwise nil
      */
     @warn_unused_result
-    public func optionalFrom<T>(field: String, transformation: AnyObject? throws -> T?) -> T? {
+    public func optionalFrom<T>(field: String, @noescape transformation: AnyObject? throws -> T?) -> T? {
         return (try? transformation(try? self.JSONFromField(field))).flatMap { $0 }
     }