This repository has been archived by the owner on May 17, 2024. It is now read-only.
Make transformations throw MissingFieldErrors #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ |
keith
force-pushed
the
ks/transformation-throws
branch
2 times, most recently
from
3a631e8
to
4f74320
Compare
When implementing custom errors I decided to make the transformation function swallow `MissingFieldError`s since we were using `rethrows` and it would have been a breaking API change. Now we're going to bump for a breaking API change, and this is more true to what is actually going wrong in order for the function to throw.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing custom errors I decided to make the transformation
function swallow
MissingFieldErrors since we were usingrethrowsandit would have been a breaking API change. Now we're going to bump for a
breaking API change, and this is more true to what is actually going
wrong in order for the function to throw.
See previous conversation https://github.com/lyft/mapper/pull/48/files#r60854250