-
-
Notifications
You must be signed in to change notification settings - Fork 66
crash when collating html reports: Unexpected node test #150
Comments
I believe that this is a problem with REXML. See this Issue. I may be able to work around this, but can you try with Ruby 2.4.1? |
Yeah, it worked on ruby 2.4.2. I'm trying to get this working on bitrise, i'll see if i can figure out how to use a different version of ruby. |
@bluwave hopefully you can find a way. I don't have a lot of time to work on this right now. It could be tricky. My initial gut reaction is that the XPath call that I am making returns a nil internally and then it crashes. My thought of a workaround entails breaking the Xpath up into smaller paths to search with valid return nodes. |
I am open to Pull Requests if you want to attempt a fix. I believe that my use of |
@bluwave can you modify your Pluginfile:
If there are still problems, please let me know and attach the console output as a text file to this issue (makes it easier for me to review). If it works, please let me know. |
Thanks for the quick fix. It did not work. I have attached the output. |
I don't think that run of fastlane is using my branch: you should not see Can you remove your |
My apologies. After retrying this and making sure it had the right branch, it worked 🎉. |
@lyndsey-ferguson I did the steps and the problem solved but the collate report issue happen again that all folders from workers removed and I got only one folder in the test results folder, it was working normally before changed the plugin file, can anyone help me in this |
@lyndsey-ferguson Please, can you merge the Open PRs? because they will solve our current problems |
@moatazeldebsy when you write merge the open PRs, are you referring just to this one:#153? The others are not related and not ready yet. I was hoping to put them all in the same release. With regards to your comment about all folders being removed, that is the intended result if you leave |
Thank you for replying , I mean All PRs, because we have different problems, we use the latest version of the Plugin and the result folders are not deleted so for example if we run on 6 devices we got 6 folders and we generate report from these folders , but we have this exception in this issue that Fastlane always failed because the error with Ruby version, I follow your steps to change the version in plugin file with the branch and the error solved but we the collate remove all the folders and give us only one folder , I add option to disable collate but the results are not accurate because all folder for the 1st run and 2 attempts are exciting and multiscan collect all of them in the summary for example if we have 25 test and run them again in retry action the results will be 50 . Because I found that all PRs are related to our issues |
Well, first this is the only PR that is ready. The other two that are open are not ready. The PR only fixes the issue where collating html files fails for Ruby v2.6+ (which looks like you are facing). From what you describe, you are experiencing this issue only. Correct? Are you facing problems with Xcode 11 and test_result bundles not collating correctly? Are you facing problems with older |
Yes with the latest version of the plugin we have this error:
and the we have all the test results folders for the 6 devices , but after I changed the |
Please be patient, but I am having difficulty understanding. Here is what I think you are saying:
I find it difficult when there are no newlines in a large paragraph. Could you make sure you create new paragraphs when responding? That may help me understand faster 😄 . Thank you for your patience and involvement! |
Ok Sorry for that, I will make it simple : 1- We are using version 2- We updated the 3- We try to solve the 4- We have also this issue Multiscan runs all the disabled tests in the scheme because we disabled test cases in the scheme but we found it in the run. Hope that is clear now :) |
Thank you!! That helps. The good news is that I should be able to merge the first two issues, I'm still waiting for tests for the disabled tests PR. |
Fixed in v3.8.7 |
New Issue Checklist
fastlane-plugin-test_center
to the latest versionIssue Description
multi_scan
appears to finish testing but get the error:
see sample project https://github.com/bluwave/TestCenterBug
xcode 11.1, catalina
Complete output when running fastlane, including the stack trace and command used
Environment
The text was updated successfully, but these errors were encountered: