fix(session#new): fix unhandled 500 when logging in with valid user and bad password #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caused by logging in with valid user, bad password, and DeviseTokenAuth.change_headers_on_each_request = false
|
@lynndylanhurley - this was a crazy dive and probably not encountered by most people due to our disabling of the default token rotation and our use of |
|
👍 tricky bug! |
booleanbetrayal
added a commit
that referenced
this pull request
Jun 16, 2015
fix(session#new): fix unhandled 500 when logging in with valid user and bad password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When token rotation is disabled, and the devise @resource is accessed within a before_filter, incorrect login credentials for an existing account can fail ungracefully causing a 500 server error instead of the expected 401. This is because both the @resource and @client_id remain set, despite falling through the failure criteria in
set_user_by_token. As these instance variables persist, they allow the after_filter update_auth_header to continue to execute unexpectedly, callingauth_header = @resource.build_auth_header(@token, @client_id). This then triggers a null-ref in build_auth_header.