Remove OmniAuth dependency #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Thank you so much 👍 The failing build is my fault - no worries! |
lynndylanhurley
added a commit
that referenced
this pull request
Sep 11, 2014
Remove OmniAuth dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13 I think.
The OmniAuth stuff is great, but if people just want email/password auth this will allow them to have that without having OmniAuth in their Gemfile. The other solution would be to add OmniAuth as a gem dependency, but it seems silly to add another gem if you don't need to.
Anyway, I ran tests prior to submit -- and some failed -- but then I looked at the build badge and it appears to be the same ones that are failing on Travis CI, and don't appear related to my changes.
Thanks for making this awesome gem! We just started implementing auth in an Angular/Rails project and thought it would take for ever-- and instead we'll have it done in a night thanks to your awesome work :)