-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added json support for tokens #276
Added json support for tokens #276
Conversation
Since the tests run with SQLite, what do you think the best way to add tests are? I just did it manually. |
hmm sorry it looks like my branch is out of sync. I'll update that soon edit: updated |
Could be nice to change column too ;) |
fwiw, I got the inspiration from this comment: #121 (comment) |
@shicholas - I think we need an additional check on Likewise, MySQL is now rolling |
okay sounds good, I will do a check for mysql and postgres with the right versions. I'll push up the some code soon. How should I test this though? Should we run the tests w/ those database versions? |
pushed, let me know what you think. |
@shicholas - LGTM ... would you mind rebasing and squashing your commits? |
In the installation generator script, the migration template checks to see if the app is using postgres by seeing what sub-class of ``ActiveRecord::ConnectionAdapter`` the app is using. If it is postgres, or mysql with the correct version, the app will use a token column instead of a text one Postgres has JSON types as of 9.3 Mysql has JSON types as of 5.7.7 http://mysqlserverteam.com/json-labs-release-native-json-data-type-and-binary-format/ teeny refactoring
np, rebased and squashed. |
thanks @shicholas ! |
Added json support for tokens
In the installation generator script, the migration template checks to see if the app is using postgres by seeing what sub-class of
ActiveRecord::ConnectionAdapter
the app is using. If it is postgres, the app will use a token column instead of a text one.