Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix privacy issue with password reset request #808

Conversation

biomancer
Copy link
Contributor

Returning resource_data in render_create_success allows anyone to get all user data that is being serialized in application from resource model by using just an email, as

POST /api/v1/auth/password with {email: 'buddy.lebsack@example.net', return_url: '...'}

returns body like that:

{
  "success": true,
  "data": {
    "id": 130,
    "uid": "buddy.lebsack@example.net",
    "unconfirmed_email": null,
    "email": "buddy.lebsack@example.net",
    "first_name": "Kiana",
    "last_name": "Kiehn",
    "organization": "Vel",
    "phone": "551-432-2662",
    ...
  },
  "message": "..."
}

I think that this is a regression that was introduced in this commit

This pr removes that data from response.

@biomancer biomancer changed the title Do not return resource data on password reset request Privacy issue with password reset request Jan 13, 2017
@biomancer biomancer changed the title Privacy issue with password reset request Fix privacy issue with password reset request Jan 13, 2017
@booleanbetrayal
Copy link
Collaborator

great catch. thanks @biomancer !

@booleanbetrayal booleanbetrayal merged commit 875682f into lynndylanhurley:master Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants