Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for testing. #840

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Feb 28, 2017

Hi there, thanks for your hard work on this gem, it'd be great if the documentation was a little bit more specific about how this worked, it was non obvious to me that there were 4 headers required to make this work (I was initially using the bearer token template in an authorization head (doh)).

Theres also no documentation in the readme about how to test this, you have to rely on searching through issues to find a solution. I've made a start at improving this here, but would welcome follow up suggestions.

I'm actually setting the headers individually as I'm using rack-test directly rather than test-unit style rails helpers.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes more things explicit, especially "each one is a separate header".

Thanks for taking the time to make these docs better.

@lynndylanhurley
Copy link
Owner

Thanks @JonRowe!!

@lynndylanhurley lynndylanhurley merged commit 33299c0 into lynndylanhurley:master Sep 29, 2017
@JonRowe JonRowe deleted the patch-2 branch September 30, 2017 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants