Upgrade test suite to use Rails 5 #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@secord_is_batch_request` -> `@second_is_batch_request`
users with different providers should be able to use the same email address. here is the line that we're overriding in devise: https://github.com/plataformatec/devise/blob/83213569dd77551bb5cac493e2767457970905bc/test/rails_app/lib/shared_admin.rb#L12
notable changes: - added rails version to migrations - updated test requests to new format - updated several test runner dependencies - various rubocop linting fixes within test suite
|
Cool, looks like #863 fixes the password reset issue. @zachfeldman @MaicolBen please take a look when you get a chance. this PR resolves a bunch of issues, but I'm gonna need another day or two to test with clients before cutting a release (#972). |
|
This is a lot! I scanned through and didn't see anything too crazy. Way to update past hash rocket hashes :). Considering this PR is from the author of the gem, and tests are passing, I'm inclined to merge it. Regressions will be evident on the next release and we're paying close attention to the issue tracker if people have problems. I'm going to approve this PR. |
zachfeldman
approved these changes
Oct 14, 2017
MaicolBen
approved these changes
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for this massive PR. Rails 5 changed the test request format and it resulted in a ton of changes to the test suite.
Notable changes:
A few bugs were revealed (and fixed) as a result of this update:
render: :nothing, which is no longer supported in Rails 5:confirmable