Google Cloud Transparent GZIP Compression Support #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaminmoo
force-pushed
the
transparent-snappy-compression
branch
from
f70df44 to
6b55a6b
Compare
vitaminmoo
changed the title
ajroetker
approved these changes
Sep 7, 2023
vitaminmoo
changed the title
ajroetker
approved these changes
Sep 19, 2023
epsniff
approved these changes
Sep 19, 2023
| @@ -13,8 +14,9 @@ func TestReaderContextDone(t *testing.T) { | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| cancel() | |||
|
|
|||
| m := memRWC([]byte("some-data")) | |||
| rc := NewReader(ctx, &m) | |||
| pr, pw := bufpipe.New([]byte("some-data")) | |||
| if len(o.metadata) == 0 { | ||
| o.metadata = make(map[string]string) | ||
| } | ||
|
|
||
| _, err = io.Copy(storecopy, cachedcopy) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
LoL, past me sucked at programming...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support gzip compression for localfs and Google Storage
This is configured such that compressed files are subject to decompressive transcoding according to https://cloud.google.com/storage/docs/transcoding - If you don't actively try, readers of these files will get the decompressed version. We download the compressed version to optimize transfer bandwidth.