test

lzchen · Jun 21, 2024 · dba3963 · dba3963
1 parent 481581e
commit dba3963
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ion/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py b/...ion/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
@@ -350,8 +350,6 @@ def collect_request_attributes(scope, sem_conv_opt_in_mode=_HTTPStabilityMode.DE
     path = scope.get("path")
     if path:
         target = path
-        if query_string:
-            target = path + query_string
         _set_http_target(result, target, path, query_string, sem_conv_opt_in_mode)
     if http_url:
         _set_http_url(result, remove_url_credentials(http_url), sem_conv_opt_in_mode)

diff --git a/instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py b/instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
@@ -789,6 +789,8 @@ def test_basic_metric_success(self):
             "http.host": "127.0.0.1",
             "http.scheme": "http",
             "http.flavor": "1.0",
+            "http.server.name"
+            "net.host.port": 80,
         }
         metrics_list = self.memory_metrics_reader.get_metrics_data()
         # pylint: disable=too-many-nested-blocks