Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit dns config #541

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Use explicit dns config #541

merged 4 commits into from
Jan 22, 2021

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jan 21, 2021

This change removes the initContainer that manually overwrites the content of /etc/resolv.conf in favor of using the native k8s support for specifying the dnsPolicy and dnsConfig -- see also: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/


This change is Reviewable

@stephen-soltesz
Copy link
Contributor Author

See also: #542

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to explicitly and completely override all cluster-local resolution

Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 LGTMs obtained

a discussion (no related file):
Thank you for this. This is far cleaner and explicit than the initContainer.


Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the answer to your question is: we do not want to override all cluster-local resolution. And, we do not know how to work with the cluster-local resolution yet.

I would prefer (almost always) to work with the system's way of doing things rather than go against the grain and build custom strategies.

In this case, I think we don't know how to do that yet while preserving our multus network configuration for experiments. If we could do both, that would be welcome.

Reviewable status: 0 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit 1b784fd into master Jan 22, 2021
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-dns branch January 22, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants