Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TCPInfo.MinRTT instead of TCPInfo.RTT #49

Merged
merged 2 commits into from
May 18, 2020

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented May 18, 2020

Show MinRTT instead of RTT in the test summary. Examples:

$ ./ndt7-client -quiet -format=json | jq
{
  "ServerFQDN": "ndt-iupui-mlab1-mil04.mlab-oti.measurement-lab.org",
  "ServerIP": "213.242.77.139",
  "ClientIP": "...",
  "DownloadUUID": "ndt-wnkr5_1589391933_0000000000051384",
  "Download": {
    "Value": 389.681259751377,
    "Unit": "Mbit/s"
  },
  "Upload": {
    "Value": 38.33447624961975,
    "Unit": "Mbit/s"
  },
  "DownloadRetrans": {
    "Value": 0.5296091494852461,
    "Unit": "%"
  },
  "MinRTT": {
    "Value": 22,
    "Unit": "ms"
  }
}
$ ./ndt7-client -quiet
         Server: ndt-iupui-mlab2-mil04.mlab-oti.measurement-lab.org
         Client: ...
        Latency:    22.0 ms
       Download:   362.8 Mbit/s
         Upload:    45.8 Mbit/s
 Retransmission:    0.76 %

Thanks @mattmathis for recommending this.


This change is Reviewable

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)

@robertodauria robertodauria merged commit b96273a into master May 18, 2020
@robertodauria robertodauria deleted the sandbox-roberto-use-minrtt branch May 18, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants