Adds an alert for when GCE costs are >50% of montly average #1063
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Would 40% have caused any false positives? I'm imagining a 40% increase, which is still pretty significant. Alternately, what is the lowest threshold that doesn't generate any false positives in the last 6mo?
Thank you for adding the wiki page summarizing this new alert.
Reviewable status: 0 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, the current daily average for the past 30 days is $11,318. On October 9th, due to the Exactly Labs bug, the Compute Engine costs were $16,965. Using >50% as the threshold would have just caught the Exactly Labs bug (11318 * 1.5 = 16977). Lowering the threshold to >25% would have triggered a false alarm on a few occasions over the past month due to normal variation in Compute Engine costs. We could probably get away with maybe a >40% threshold, but >50% seemed like a nice round number and will catch the more serious increases after a couple days.
This change is