Skip to content

Commit

Permalink
White space Fix log and error messages (apache#30804)
Browse files Browse the repository at this point in the history
* missing space between words for truncated string in source code
  • Loading branch information
Abacn authored Apr 3, 2024
1 parent 3caa1d8 commit 61eee6d
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public String create(PipelineOptions options) {
} catch (Exception e) {
throw new IllegalArgumentException(
"Error constructing default value for stagingLocation: failed to retrieve gcpTempLocation. "
+ "Either stagingLocation must be set explicitly or a valid value must be provided"
+ "Either stagingLocation must be set explicitly or a valid value must be provided "
+ "for gcpTempLocation.",
e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public interface DataflowStreamingPipelineOptions extends PipelineOptions {

@Description(
"If non-null, StreamingDataflowWorkerHarness will periodically snapshot it's status pages"
+ "and thread stacks to a file in this directory. Generally only set for tests.")
+ " and thread stacks to a file in this directory. Generally only set for tests.")
@Default.InstanceFactory(PeriodicStatusPageDirectoryFactory.class)
String getPeriodicStatusPageOutputDirectory();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public State cancel() throws IOException {
@Override
public State waitUntilFinish(Duration duration) {
Log.debug(
"Twister2 runner does not currently support wait with duration"
"Twister2 runner does not currently support wait with duration "
+ "default waitUntilFinish will be executed");
return waitUntilFinish();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ private void validateErrorHandlers() {
for (ErrorHandler<?, ?> errorHandler : errorHandlers) {
if (!errorHandler.isClosed()) {
throw new IllegalStateException(
"One or more ErrorHandlers aren't closed, and this pipeline"
"One or more ErrorHandlers aren't closed, and this pipeline "
+ "cannot be run. See the ErrorHandler documentation for expected usage");
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ public void encode(Object value, OutputStream outStream) throws CoderException,
"`UnknownCoderWrapper` was used to perform an actual encoding in the Java SDK. "
+ "Potentially a `PCollection` that was generated by a cross-language transform, "
+ "that uses a coder that is not available in the Java SDK, is being consumed by a Java"
+ "transform. Please make sure that cross-language transforms at the language"
+ " transform. Please make sure that cross-language transforms at the language "
+ "boundary use Beam portable coders.");
}

@Override
public Object decode(InputStream inStream) throws CoderException, IOException {
throw new CoderException(
"`UnknownCoderWrapper` was used to perform an actual decoding in the Java SDK. "
+ "Potentially a Java transform is being followed by a cross-language transform that"
+ "Potentially a Java transform is being followed by a cross-language transform that "
+ "uses a coder that is not available in the Java SDK. Please make sure that Python "
+ "transforms at the multi-language boundary use Beam portable coders.");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public void testParDoRequiresStableInput() {
value -> {
throw new RuntimeException(
"Deliberate failure: should happen only once for each application of the DoFn"
+ "within the transform graph.");
+ " within the transform graph.");
};

PCollection<String> singleton = p.apply("CreatePCollectionOfOneValue", Create.of(VALUE));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public void visitPrimitiveTransform(Node node) {
checkState(
viewRef.compareAndSet(null, createViewTransform.getView()),
"Found more than one instance of a CreatePCollectionView when"
+ "attempting to replace %s, found [%s, %s]",
+ " attempting to replace %s, found [%s, %s]",
transform.getTransform(),
viewRef.get(),
createViewTransform.getView());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ public FileReadSchemaTransformConfiguration build() {
if (terminateAfterSecondsSinceNewOutput != null && terminateAfterSecondsSinceNewOutput > 0L) {
checkArgument(
pollIntervalMillis != null && pollIntervalMillis > 0L,
"Found positive value for terminateAfterSecondsSinceNewOutput but non-positive"
"Found positive value for terminateAfterSecondsSinceNewOutput but non-positive "
+ "value for pollIntervalMillis. Please set pollIntervalMillis as well to enable"
+ "watching for new files.");
+ " watching for new files.");
}
return config;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ Optional<ValueProvider<String>> getImportGcsDeadLetterPath() {
public Write.Result expand(PCollection<String> input) {
checkState(
input.isBounded() == IsBounded.BOUNDED,
"FhirIO.Import should only be used on bounded PCollections as it is"
"FhirIO.Import should only be used on bounded PCollections as it is "
+ "intended for batch use only.");

// fall back on pipeline's temp location.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,7 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin input) {
if (kafkaRead.getBadRecordErrorHandler() != null) {
LOG.warn(
"The Legacy implementation of Kafka Read does not support writing malformed"
+ "messages to an error handler. Use the SDF implementation instead.");
+ " messages to an error handler. Use the SDF implementation instead.");
}
// Handles unbounded source to bounded conversion if maxNumRecords or maxReadTime is set.
Unbounded<KafkaRecord<K, V>> unbounded =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public Row toConfigRow(Read<?, ?> transform) {
if (transform.getBadRecordErrorHandler() != null) {
throw new RuntimeException(
"Upgrading KafkaIO read transforms that have `withBadRecordErrorHandler` property set"
+ "is not supported yet.");
+ " is not supported yet.");
}

return Row.withSchema(schema).withFieldValues(fieldValues).build();
Expand Down Expand Up @@ -505,7 +505,7 @@ public Row toConfigRow(Write<?, ?> transform) {
instanceof ErrorHandler.DefaultErrorHandler)) {
throw new RuntimeException(
"Upgrading KafkaIO write transforms that have `withBadRecordErrorHandler` property set"
+ "is not supported yet.");
+ " is not supported yet.");
}

return Row.withSchema(schema).withFieldValues(fieldValues).build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ void setPubsubMessageSerializationMethod(

@Description(
"If non-negative, events from the Kafka topic will get their timestamps from the Kafka createtime, with the maximum delay for"
+ "disorder as specified.")
+ " disorder as specified.")
@Default.Integer(60)
int getKafkaTopicCreateTimeMaxDelaySec();

Expand Down

0 comments on commit 61eee6d

Please sign in to comment.