-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fingerprint login method #244
Conversation
0ea5017
to
50c99dc
Compare
I feel like we should implement CrAzYpass on this as well, before it gets merged. But really good work! |
e321ae9
to
ed6f611
Compare
this is really nice!!
|
About last item,
|
Security warning is a good idea. Two small changes to your text:
|
Thanks for your correction. Now, app will pop up security warning when user enables this function. |
actually, it's not totally true about replacing the app with a hacked one because the app signatures have to match. but I think the security warning is the way to go nonetheless. |
You're right.
|
@erciccione this adds some new strings:
chinese is already done |
Related issue: #229
In the current implementation, we have to enter password to open wallet.
To implement fingerprint login method, i think we need to save user password in a secure method for future use.
Therefore, in this commit, if user allows to open wallet using fingerprint, app will encrypt user password (not CrAzYpass) using RSA algorithm and save ciphertext in SharedPreferences.
On access to the wallet, user can touch fingerprint sensor to use saved password to unlock the wallet.