Skip to content

Commit

Permalink
Change levels, fix lint and add proper abort message if/when failure …
Browse files Browse the repository at this point in the history
…condition unknown
  • Loading branch information
robskillington committed Jun 7, 2022
1 parent d9589f2 commit 757fefb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
9 changes: 5 additions & 4 deletions src/dbnode/integration/graphite_find_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ local:
)
switch testOpts.datasetSize {
case smallDatasetSize:
levels = 5
entriesPerLevelMin = 5
entriesPerLevelMax = 7
levels = 4
entriesPerLevelMin = 7
entriesPerLevelMax = 10
case largeDatasetSize:
// Ideally we'd always use a large dataset size, however you do need
// high concurrency to validate this entire dataset and CI can't seem
Expand Down Expand Up @@ -334,7 +334,8 @@ local:
assert.NoError(t, err)
log.Error("aborting checks due to error")
default:

require.FailNow(t, "unknown error condition")
log.Error("aborting checks due to unknown condition")
}
}
})
Expand Down
3 changes: 1 addition & 2 deletions src/dbnode/storage/coldflush.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ func (m *coldFlushManager) Run(t xtime.UnixNano) bool {
m.Unlock()
}()


if log := m.log.Check(zapcore.DebugLevel, "cold flush run start"); log != nil {
log.Write(zap.Time("time", t.ToTime()))
}
Expand All @@ -132,7 +131,7 @@ func (m *coldFlushManager) Run(t xtime.UnixNano) bool {
zap.Time("time", t.ToTime()), zap.Error(err))
})
}

if log := m.log.Check(zapcore.DebugLevel, "cold flush run complete"); log != nil {
log.Write(zap.Time("time", t.ToTime()))
}
Expand Down

0 comments on commit 757fefb

Please sign in to comment.