Skip to content

Commit

Permalink
add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Richard Artoul committed Dec 14, 2018
1 parent cacf751 commit a3d618a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/dbnode/storage/namespace.go
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,10 @@ func (n *dbNamespace) Snapshot(
n.RUnlock()

if !n.nopts.SnapshotEnabled() {
// Note that we keep the abbility to disable snapshots at the namespace level around for
// debugging / performance / flexibility reasons, but disabling it can / will cause data
// loss due to the commitlog cleanup logic assuming that a valid snapshot checkpoint file
// means that all namespaces were successfully snapshotted.
n.metrics.snapshot.ReportSuccess(n.nowFn().Sub(callStart))
return nil
}
Expand Down

0 comments on commit a3d618a

Please sign in to comment.