Add sort and sort_desc #1104
Merged
Add sort and sort_desc #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnikola
reviewed
Oct 17, 2018
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
+ Coverage 70.13% 70.16% +0.03%
==========================================
Files 670 670
Lines 55644 55663 +19
==========================================
+ Hits 39024 39056 +32
+ Misses 14098 14087 -11
+ Partials 2522 2520 -2
Continue to review full report at Codecov.
|
added 3 commits
October 18, 2018 11:14
benraskin92
force-pushed
the
braskin/add-sort
branch
from
bfd9b8e
to
6152ff2
Compare
nikunjgit
approved these changes
Oct 18, 2018
arnikola
reviewed
Oct 18, 2018
| @@ -160,11 +160,15 @@ func (p *parseState) walk(node pql.Node) error { | |||
| } | |||
| } | |||
|
|
|||
| op, err := NewFunctionExpr(n.Func.Name, argValues, stringValues) | |||
| op, ok, err := NewFunctionExpr(n.Func.Name, argValues, stringValues) | |||
There was a problem hiding this comment.
Would prefer this check here for n.func.name and return nil if it's a sort, rather than adding awkward third return param
arnikola
reviewed
Oct 18, 2018
| // NB: Because Prometheus's sort and sort_desc only look at the last value, | ||
| // these functions are essentially noops in M3 as we don't support instant queries. | ||
|
|
||
| // SortType returns timeseries elements sorted by their values, in ascending order. |
There was a problem hiding this comment.
This file seems unnecessary? Would prefer to keep these in parser, as this doesn't add too much context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.