Dont use pool for allocating tag slices #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
=========================================
- Coverage 70.7% 46.2% -24.6%
=========================================
Files 765 751 -14
Lines 64378 62649 -1729
=========================================
- Hits 45570 28968 -16602
- Misses 15853 30990 +15137
+ Partials 2955 2691 -264
Continue to review full report at Codecov.
|
justinjc
approved these changes
Jan 17, 2019
src/dbnode/storage/shard.go
Outdated
| seriesID, tagsIter, s.identifierPool) | ||
|
|
||
| // Pass nil for the identifier pool because the pool will force us to use an array | ||
| // with a large capacity to store the tags. Since these tags are long-lived, its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.