Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race/panic in index query code #1356

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Fix race/panic in index query code #1356

merged 1 commit into from
Feb 7, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1356 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1356     +/-   ##
========================================
+ Coverage    70.7%   70.7%   +<.1%     
========================================
  Files         822     822             
  Lines       70333   70335      +2     
========================================
+ Hits        49778   49789     +11     
+ Misses      17320   17312      -8     
+ Partials     3235    3234      -1
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.6% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.9% <100%> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.8% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 64.3% <ø> (ø) ⬆️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5b945...1ca88a8. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1356 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1356     +/-   ##
========================================
+ Coverage    70.7%   70.7%   +<.1%     
========================================
  Files         822     822             
  Lines       70333   70335      +2     
========================================
+ Hits        49778   49789     +11     
+ Misses      17320   17312      -8     
+ Partials     3235    3234      -1
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.6% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.9% <100%> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.8% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 64.3% <ø> (ø) ⬆️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5b945...1ca88a8. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1356 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1356     +/-   ##
========================================
+ Coverage    70.7%   70.7%   +<.1%     
========================================
  Files         822     822             
  Lines       70333   70335      +2     
========================================
+ Hits        49778   49789     +11     
+ Misses      17320   17312      -8     
+ Partials     3235    3234      -1
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.6% <ø> (-0.1%) ⬇️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.9% <100%> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.2% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.8% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 64.3% <ø> (ø) ⬆️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5b945...1ca88a8. Read the comment docs.

prateek
prateek approved these changes Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@prateek prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit b2232b0 into master Feb 7, 2019
@robskillington robskillington deleted the ra/fix-query-panic branch February 7, 2019 17:12
robskillington
robskillington reviewed Feb 7, 2019
View reviewed changes
src/dbnode/storage/index_query_concurrent_test.go
@@ -248,6 +274,8 @@ func testNamespaceIndexHighConcurrentQueries(
rangeEnd := blockStarts[k].Add(test.indexBlockSize)

ctx := context.NewContext()
defer ctx.Close()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really shouldn't defer from within a for loop, but.. ok haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robskillington robskillington robskillington left review comments

@prateek prateek prateek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardartoul @prateek @robskillington