Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain a lock on filePathPrefix on dbnode startup. Close #641 #1376

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Obtain a lock on filePathPrefix on dbnode startup. Close #641 #1376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba2bcc
Obtain a lock on `filePathPrefix` on dbnode startup. Close #641
edkolev Feb 14, 2019
4b5d89a
Merge branch 'master' into obtain-a-lock-on-file-path-prefix-on-startup
richardartoul Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions src/dbnode/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"net/http"
"os"
"os/signal"
"path"
"runtime"
"runtime/debug"
"syscall"
Expand Down Expand Up @@ -67,6 +68,7 @@ import (
"github.com/m3db/m3/src/m3ninx/postings"
"github.com/m3db/m3/src/m3ninx/postings/roaring"
xdocs "github.com/m3db/m3/src/x/docs"
"github.com/m3db/m3/src/x/lockfile"
"github.com/m3db/m3/src/x/mmap"
"github.com/m3db/m3/src/x/serialize"
xconfig "github.com/m3db/m3x/config"
Expand All @@ -87,6 +89,7 @@ const (
serverGracefulCloseTimeout = 10 * time.Second
bgProcessLimitInterval = 10 * time.Second
maxBgProcessLimitMonitorDuration = 5 * time.Minute
filePathPrefixLockFile = ".lock"
)

// RunOptions provides options for running the server
Expand Down Expand Up @@ -144,6 +147,29 @@ func Run(runOpts RunOptions) {
os.Exit(1)
}

newFileMode, err := cfg.Filesystem.ParseNewFileMode()
if err != nil {
logger.Fatalf("could not parse new file mode: %v", err)
}

newDirectoryMode, err := cfg.Filesystem.ParseNewDirectoryMode()
if err != nil {
logger.Fatalf("could not parse new directory mode: %v", err)
}

// Obtain a lock on `filePathPrefix`, or exit if another process already has it.
// The lock consists of a lock file (on the file system) and a lock in memory.
// When the process exits gracefully, both the lock file and the lock will be removed.
// If the process exits ungracefully, only the lock in memory will be removed, the lock
// file will remain on the file system. When a dbnode starts after an ungracefully stop,
// it will be able to acquire the lock despite the fact the the lock file exists.
lockPath := path.Join(cfg.Filesystem.FilePathPrefixOrDefault(), filePathPrefixLockFile)
fslock, err := lockfile.CreateAndAcquire(lockPath, newDirectoryMode)
if err != nil {
logger.Fatalf("could not acquire lock on %s: %v", lockPath, err)
}
defer fslock.Release()

go bgValidateProcessLimits(logger)
debug.SetGCPercent(cfg.GCPercentage)

Expand Down Expand Up @@ -290,16 +316,6 @@ func Run(runOpts RunOptions) {

opts = opts.SetRuntimeOptionsManager(runtimeOptsMgr)

newFileMode, err := cfg.Filesystem.ParseNewFileMode()
if err != nil {
logger.Fatalf("could not parse new file mode: %v", err)
}

newDirectoryMode, err := cfg.Filesystem.ParseNewDirectoryMode()
if err != nil {
logger.Fatalf("could not parse new directory mode: %v", err)
}

mmapCfg := cfg.Filesystem.MmapConfigurationOrDefault()
shouldUseHugeTLB := mmapCfg.HugeTLB.Enabled
if shouldUseHugeTLB {
Expand Down