Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add m3ninx/AllQuery #1478

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Add m3ninx/AllQuery #1478

merged 4 commits into from
Mar 20, 2019

Conversation

prateek
Copy link
Collaborator

@prateek prateek commented Mar 20, 2019

No description provided.

arnikola
arnikola approved these changes Mar 20, 2019
View reviewed changes
Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though not a fan of the name AllQuery

src/m3ninx/search/query/all.go Outdated
"github.com/m3db/m3/src/m3ninx/search/searcher"
)

// AllQuery returns a query which matches all the known documents.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: all known documents

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

src/m3ninx/search/query/codec.go
}

return nil, fmt.Errorf("unknown query: %v", q)
return nil, fmt.Errorf("unknown query: %+v", q)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, didn't know about this, it's pretty neat 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol :)

richardartoul
richardartoul reviewed Mar 20, 2019
View reviewed changes
Copy link
Contributor

@richardartoul richardartoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the point of this P.R? Is it just so we have an easy way of special-casing these types of queries?

@arnikola
Copy link
Collaborator

Whats the point of this P.R? Is it just so we have an easy way of special-casing these types of queries?

I think it's primarily to make an explicit query type for tag matching v.s. regex matching .* or something; in future, could be useful for specifying the special case of listing all tags without providing a query

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #1478 into master will decrease coverage by <.1%.
The diff coverage is 81.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1478     +/-   ##
========================================
- Coverage    70.9%   70.8%   -0.1%     
========================================
  Files         841     843      +2     
  Lines       71909   71927     +18     
========================================
+ Hits        50988   50994      +6     
- Misses      17574   17581      +7     
- Partials     3347    3352      +5
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.8% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 80.7% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.3% <81.4%> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.5% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 66% <ø> (ø) ⬆️
#x 76.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fffb9...b1a0fa9. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #1478 into master will decrease coverage by <.1%.
The diff coverage is 81.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1478     +/-   ##
========================================
- Coverage    70.9%   70.8%   -0.1%     
========================================
  Files         841     843      +2     
  Lines       71909   71927     +18     
========================================
+ Hits        50988   50994      +6     
- Misses      17574   17581      +7     
- Partials     3347    3352      +5
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.8% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 80.7% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.3% <81.4%> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.5% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 66% <ø> (ø) ⬆️
#x 76.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fffb9...57b810b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #1478 into master will decrease coverage by <.1%.
The diff coverage is 81.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1478     +/-   ##
========================================
- Coverage    70.9%   70.8%   -0.1%     
========================================
  Files         841     843      +2     
  Lines       71909   71927     +18     
========================================
+ Hits        50988   50994      +6     
- Misses      17574   17581      +7     
- Partials     3347    3352      +5
Flag Coverage Δ
#aggregator 82.3% <ø> (ø) ⬆️
#cluster 85.8% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 80.7% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.3% <81.4%> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.5% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 66% <ø> (ø) ⬆️
#x 76.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fffb9...57b810b. Read the comment docs.

@prateek
Copy link
Collaborator Author

prateek commented Mar 20, 2019

Pretty much what you guys are saying - need an explicit way for users of m3db/client to be able to specify the lack of any filtering for aggregation queries

@prateek prateek merged commit 170a3a7 into master Mar 20, 2019
@prateek prateek deleted the prateek/m3ninx/match-all-query branch March 20, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardartoul richardartoul richardartoul left review comments

@arnikola arnikola arnikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prateek @arnikola @richardartoul