[dbnode] Add Prometheus process collector with open FD reporting disabled #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
========================================
+ Coverage 72.3% 72.3% +<.1%
========================================
Files 962 963 +1
Lines 80157 80260 +103
========================================
+ Hits 57967 58053 +86
- Misses 18398 18406 +8
- Partials 3792 3801 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
========================================
+ Coverage 72.3% 72.3% +<.1%
========================================
Files 962 963 +1
Lines 80157 80260 +103
========================================
+ Hits 57967 58044 +77
- Misses 18398 18415 +17
- Partials 3792 3801 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Recently we introduced a more optimized open FD reporter to replace the Prometheus collector which exhibited significant load querying open FDs by the process. This however removed some stats that some existing dashboards currently rely on. This adds those back with a modified version of the collector that turns off open FD reporting.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: