Fix multiple blocks with the same block start returned from fetchblocks pathway #1707
Conversation
richardartoul
requested review from
justinjc,
robskillington,
Haijuncao,
simonrobb and
prateek
src/dbnode/storage/series/reader.go
Outdated
| // TODO(r): pool these results arrays | ||
| // Two-dimensional slice such that the first dimension is unique by blockstart | ||
| // and the second dimension is blocks of data for that blockstart (not necessarily | ||
| // in chronological order). |
There was a problem hiding this comment.
Seems like a copy pasta comment from above that doesn't follow here.
There was a problem hiding this comment.
I refactored it to be more clear, take another look
src/dbnode/storage/series/reader.go
Outdated
| // in chronological order). | ||
| // | ||
| // ex. (querying 2P.M -> 6P.M with a 2-hour blocksize): | ||
| // [][]block.FetchBlockResult{ |
There was a problem hiding this comment.
This is actually a 1D slice which is one block start per element.
There was a problem hiding this comment.
Refactored to be more clear, take another look
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
=========================================
- Coverage 71.9% 43.9% -28%
=========================================
Files 970 944 -26
Lines 81427 79516 -1911
=========================================
- Hits 58551 34961 -23590
- Misses 19037 41330 +22293
+ Partials 3839 3225 -614
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
=========================================
- Coverage 71.9% 43.9% -28%
=========================================
Files 970 944 -26
Lines 81427 79516 -1911
=========================================
- Hits 58551 34961 -23590
- Misses 19037 41330 +22293
+ Partials 3839 3225 -614
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
========================================
- Coverage 71.9% 65.4% -6.6%
========================================
Files 976 972 -4
Lines 81530 81350 -180
========================================
- Hits 58693 53253 -5440
- Misses 18996 24346 +5350
+ Partials 3841 3751 -90
Continue to review full report at Codecov.
|
richardartoul
force-pushed
the
ra/fetch-blocks-fix
branch
from
f711978
to
d7a4cb0
Compare
richardartoul
force-pushed
the
ra/fetch-blocks-fix
branch
from
ed783b1
to
33b6bdd
Compare
Fixes #1640
@martin-mao This is the bug we were talking about last time I saw you.