Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] build setcap from alpine 3.9 #1850

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Conversation

schallert
Copy link
Collaborator

There's an incompatibility between our version of git and Glide. It's
easier to downgrade our alpine build image (and thus git version) rather
than upgrade glide, as we have to move off of glide anyway.

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

There's an incompatibility between our version of git and Glide. It's
easier to downgrade our alpine build image (and thus git version) rather
than upgrade glide, as we have to move off of glide anyway.
Copy link
Contributor

@nerd0 nerd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@schallert schallert merged commit 3fe451b into master Aug 2, 2019
@schallert schallert deleted the schallert/fix_docker branch August 2, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants