-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[x/config] Deprecate src/x/config/listenaddress #2017
Conversation
6edec09
to
b2ebe21
Compare
config/README.md
Outdated
``` | ||
|
||
and an environment of `MY_ENV_VAR=bar`, we will load: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will load -> the interpolated YAML will be:
cfd0c9e
to
cbecd75
Compare
b2ebe21
to
ef22da5
Compare
cbecd75
to
b75aa5e
Compare
ef22da5
to
c181db8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
=========================================
- Coverage 63.1% 59.7% -3.4%
=========================================
Files 1079 1105 +26
Lines 105667 104676 -991
=========================================
- Hits 66679 62519 -4160
- Misses 34816 37970 +3154
- Partials 4172 4187 +15
Continue to review full report at Codecov.
|
b75aa5e
to
262f771
Compare
c181db8
to
6363f16
Compare
What this PR does / why we need it: Given #2016, we no longer need a homebrew means of resolving ports from the environment. Users who want this functionality can now do:
Given sufficient documentation (hopefully provided), this is imo simpler and easier to grok behavior-wise than the homebrewed solution we were using before.
The change should be backwards compatible; anyone using
type: environment
will still have theiror
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: