Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Add latency metrics to remote reads #2027

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Conversation

arnikola
Copy link
Collaborator

What this PR does / why we need it:
Adds metrics for latency on the remote read path

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #2027 into master will decrease coverage by 6.1%.
The diff coverage is 88.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2027     +/-   ##
========================================
- Coverage    71.9%   65.7%   -6.2%     
========================================
  Files         971    1000     +29     
  Lines       84655   85826   +1171     
========================================
- Hits        60913   56466   -4447     
- Misses      19678   25336   +5658     
+ Partials     4064    4024     -40
Flag Coverage Δ
#aggregator 45.4% <ø> (-19.4%) ⬇️
#cluster 59.4% <ø> (-26.1%) ⬇️
#collector 54.9% <ø> (ø) ⬆️
#dbnode 76.7% <ø> (+6.7%) ⬆️
#m3em 32.5% <0%> (-25.3%) ⬇️
#m3ninx 60.6% <ø> (-7.5%) ⬇️
#m3nsch 60.5% <ø> (-9.5%) ⬇️
#metrics 53.8% <ø> (+36%) ⬆️
#msg 74.9% <ø> (+0.1%) ⬆️
#query 54.4% <88.8%> (+15.2%) ⬆️
#x 84% <ø> (+8.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a114d4...26d55b4. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington changed the title [query] add latency metrics to remote reads [query] Add latency metrics to remote reads Oct 29, 2019
@arnikola arnikola merged commit 1461ce6 into master Oct 30, 2019
@arnikola arnikola deleted the arnikola/record-timer branch October 30, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants