-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proto] Add Prometheus Protobuf definitions to support annotations #2029
[proto] Add Prometheus Protobuf definitions to support annotations #2029
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
======================================
Coverage 72.3% 72.3%
======================================
Files 1003 1003
Lines 86612 86612
======================================
Hits 62659 62659
Misses 19730 19730
Partials 4223 4223
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
======================================
Coverage 72.3% 72.3%
======================================
Files 1004 1004
Lines 86613 86613
======================================
Hits 62671 62671
Misses 19720 19720
Partials 4222 4222
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
======================================
Coverage 72.8% 72.8%
======================================
Files 1006 1006
Lines 86164 86164
======================================
Hits 62742 62742
Misses 19211 19211
Partials 4211 4211
Continue to review full report at Codecov.
|
b1e08c1
to
9503d54
Compare
That sounds like a sane approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This PR adds Protobuf definitions for annotated datapoints to the
m3prometheus
package. These types will be part of an experimental API for supporting exemplars. I chose to create new types instead of augmenting the existingSample
type because support for annotations will be experimental to start and may undergo significant revisions. Introducing a new type may result in some code duplication but will help us ensure that the changes we make for annotations can be independent from the established types for Prometheus remote read and write.Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: