Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gauge for the number of active routines #2061

Merged

Conversation

simonrobb
Copy link
Contributor

@simonrobb simonrobb commented Dec 5, 2019

The existing instrumentation in PooledWorkerPool emits the number of workers currently in the pool. This PR instruments the number of workers currently engaged in work, so that a utilization percentage may be calculated.

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #2061 into master will increase coverage by 1.4%.
The diff coverage is 71.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2061     +/-   ##
========================================
+ Coverage    69.7%   71.1%   +1.4%     
========================================
  Files        1013     977     -36     
  Lines       87564   86965    -599     
========================================
+ Hits        61049   61856    +807     
+ Misses      22152   20907   -1245     
+ Partials     4363    4202    -161
Flag Coverage Δ
#aggregator 79.4% <ø> (+32.2%) ⬆️
#cluster 58% <ø> (+7.7%) ⬆️
#collector 26.7% <ø> (-18.4%) ⬇️
#dbnode 76.5% <ø> (+31.2%) ⬆️
#m3em 74.2% <ø> (+9.5%) ⬆️
#m3ninx 51.4% <ø> (-19.1%) ⬇️
#m3nsch 76.7% <ø> (+16.2%) ⬆️
#metrics 37.7% <ø> (+19.9%) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 68.9% <ø> (+0.5%) ⬆️
#x 62.8% <71.4%> (-9.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54cdb87...bed618b. Read the comment docs.

@simonrobb simonrobb force-pushed the srobb/instrument-active-routines-async-replication branch from bed618b to 8362a70 Compare December 6, 2019 17:31
Copy link
Collaborator

@justinjc justinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@simonrobb simonrobb merged commit 7e54ccf into master Dec 6, 2019
@robskillington robskillington deleted the srobb/instrument-active-routines-async-replication branch December 10, 2019 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants