[coordinator] Add continue to rule when matching Graphite rules #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## r/fix-graphite-tag-options-end-to-end #2063 +/- ##
========================================================================
+ Coverage 59.4% 72% +12.6%
========================================================================
Files 864 1006 +142
Lines 76619 86990 +10371
========================================================================
+ Hits 45555 62699 +17144
+ Misses 27533 20024 -7509
- Partials 3531 4267 +736
Continue to review full report at Codecov.
|
arnikola
reviewed
Jan 2, 2020
Comment on lines
250
to
251
| // Break because we only want to apply one rule per metric based on which | ||
| // ever one matches first. |
There was a problem hiding this comment.
This comment is no longer valid right?
arnikola
reviewed
Jan 3, 2020
| break | ||
| } | ||
| } | ||
| err := i.writeWithOptions(ctx, resources, timestamp, value, |
There was a problem hiding this comment.
Could throw these writes into a consumer queue if rule.rule.Continue is true? Don't know if it's necessary atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows multiple graphite rules to be matched.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: