-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbnode] Decode avoid checked bytes in segment reader #2190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
=======================================
- Coverage 72.2% 71.3% -1%
=======================================
Files 1019 1019
Lines 88430 88433 +3
=======================================
- Hits 63916 63116 -800
- Misses 20234 20982 +748
- Partials 4280 4335 +55
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Targeting the unchecked byte reads
Looks like a ~7% improvement in the small-byte-count case (e.g. benchmark on 10 instead of 2000).
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: