Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix namespace resolve debug log not being written with multiple namespaces #2211

Merged
merged 3 commits into from
Mar 13, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Fixes checked debug log being reused, which is unsafe.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2211 into master will increase coverage by 0.7%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2211     +/-   ##
========================================
+ Coverage    71.5%   72.2%   +0.7%     
========================================
  Files        1022    1022             
  Lines       88843   88794     -49     
========================================
+ Hits        63534   64178    +644     
+ Misses      21023   20317    -706     
- Partials     4286    4299     +13     
Flag Coverage Δ
#aggregator 82.1% <ø> (-0.1%) ⬇️
#cluster 85.3% <ø> (ø)
#collector 82.8% <ø> (ø)
#dbnode 79.0% <ø> (+1.0%) ⬆️
#m3em 74.4% <ø> (+16.2%) ⬆️
#m3ninx 72.3% <ø> (ø)
#m3nsch 51.1% <ø> (ø)
#metrics 17.6% <ø> (ø)
#msg 74.9% <ø> (ø)
#query 68.6% <66.6%> (+0.1%) ⬆️
#x 83.2% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60ce51...4c136d0. Read the comment docs.

@robskillington robskillington changed the title [query] Fix namespace resolvedebug log not being written with multiple namespaces [query] Fix namespace resolve debug log not being written with multiple namespaces Mar 13, 2020
@robskillington robskillington merged commit 14a3f8c into master Mar 13, 2020
@robskillington robskillington deleted the r/checked-entry-log-inner-loop branch March 13, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants