[coordinator] Use tag options specified in config with M3Msg ingester #2212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
========================================
+ Coverage 72.1% 72.3% +0.1%
========================================
Files 1022 1022
Lines 89022 88809 -213
========================================
- Hits 64217 64213 -4
+ Misses 20520 20281 -239
- Partials 4285 4315 +30
Continue to review full report at Codecov.
|
src/query/server/query.go
Outdated
| if downsamplerReadyCh != nil { | ||
| downsamplerReadyCh <- struct{}{} | ||
| } |
There was a problem hiding this comment.
delete this? should get done in the defer right?
There was a problem hiding this comment.
This is in an else clause - defer is inside an inner function inside the other side of the else.
There was a problem hiding this comment.
Ah, then won’t you miss a send when the newDownsamplerFn errors on this branch? Can we defer before this if else to avoid this? Could see this being a bit dangerous going forward
There was a problem hiding this comment.
I'll move it into newDownsamplerFn so it's only done in one place.
I can't defer from the top level function since some of these are async clients and are not ready by the end of the top level function creating these async clients.
For some further contextDownsamplerReadyCh is only used by tests to ensure failures to write a datapoint doesn't fail due to the async downsampler being not ready. The DownsamplerReadyCh should not be notified unless the downsampler is truly ready, if an error occurs then the channel should never receive an update.
robskillington
deleted the
r/use-configured-tag-options-for-m3msg-ingester
branch
What this PR does / why we need it:
Previously the default tag options were being used for the M3Msg ingester with the coordinator, this uses the configured tag options for the coordinator with the M3Msg ingester.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: