Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Add tracing for bootstrap process #2216

Merged
merged 6 commits into from
Apr 27, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Adds tracing for DB node bootstrapping.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like may need to mockgen and maybe update a couple of tests unfortunately, LGTM otherwise

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2216 into master will decrease coverage by <.1%.
The diff coverage is 68.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2216     +/-   ##
========================================
- Coverage    72.4%   72.4%   -0.1%     
========================================
  Files        1022    1022             
  Lines       88865   88925     +60     
========================================
+ Hits        64386   64387      +1     
- Misses      20162   20206     +44     
- Partials     4317    4332     +15
Flag Coverage Δ
#aggregator 82% <ø> (-0.1%) ⬇️
#cluster 85.3% <ø> (ø) ⬆️
#collector 82.8% <ø> (ø) ⬆️
#dbnode 79% <68.3%> (-0.2%) ⬇️
#m3em 74.4% <ø> (ø) ⬆️
#m3ninx 74.4% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.5% <ø> (ø) ⬆️
#msg 74.8% <ø> (-0.2%) ⬇️
#query 68.9% <ø> (ø) ⬆️
#x 83.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ca215...bfb52a1. Read the comment docs.

@robskillington
Copy link
Collaborator Author

Going to take @arnikola 's LGTM as a stamp.

@robskillington robskillington merged commit 542d128 into master Apr 27, 2020
@robskillington robskillington deleted the r/add-bootstrap-trace branch April 27, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants