Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Log query errors with query params #2225

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

This helps debug whether timeout's are being applied as expected, and also which errors are causing which logged errors operators encounter.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #2225 into master will decrease coverage by 12.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2225      +/-   ##
=========================================
- Coverage    72.3%   59.8%   -12.5%     
=========================================
  Files        1023     784     -239     
  Lines       88918   69631   -19287     
=========================================
- Hits        64322   41691   -22631     
- Misses      20247   24399    +4152     
+ Partials     4349    3541     -808     
Flag Coverage Δ
#aggregator 69.3% <ø> (-12.8%) ⬇️
#cluster 28.4% <ø> (-56.8%) ⬇️
#collector 50.9% <ø> (-32.0%) ⬇️
#dbnode 70.0% <ø> (-8.9%) ⬇️
#m3em 74.4% <ø> (ø)
#m3ninx 51.2% <ø> (-23.3%) ⬇️
#m3nsch 28.4% <ø> (-22.8%) ⬇️
#metrics 17.5% <ø> (ø)
#msg 74.0% <ø> (-0.8%) ⬇️
#query ?
#x 63.1% <ø> (-19.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445ee73...b486035. Read the comment docs.

@robskillington robskillington merged commit 637abd6 into master Mar 24, 2020
@robskillington robskillington deleted the r/log-query-errors-with-query branch March 24, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants