-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbnode/query] Optionally error if query exceeds series limit via RequireExhaustive config #2400
Merged
Merged
Changes from 8 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f00fc1f
err in case of limit exceeded 1
rallen090 51abb38
err in case of limit exceeded 2
rallen090 577f0ee
err in case of limit exceeded 3
rallen090 e14be6c
err in case of limit exceeded 4
rallen090 cb6f587
require exhaustive error test cases
rallen090 9fc7056
Merge remote-tracking branch 'origin/master' into ra/err-query-over-l…
rallen090 108e7a4
require exhaustive error test cases 2
rallen090 f9545bb
Merge remote-tracking branch 'origin/master' into ra/err-query-over-l…
rallen090 130c1af
Merge remote-tracking branch 'origin/master' into ra/err-query-over-l…
rallen090 3ea215b
test cases for allowing non-exhaustive 1
rallen090 e689811
test cases for allowing non-exhaustive 2
rallen090 ebf1f51
test cases for allowing non-exhaustive 3
rallen090 29d1ae8
test cases for allowing non-exhaustive 4
rallen090 6c117b6
Merge remote-tracking branch 'origin/master' into ra/err-query-over-l…
rallen090 596759c
test cases for allowing non-exhaustive 5
rallen090 34cbaef
dbnode mock gen
rallen090 39475d0
Merge remote-tracking branch 'origin/master' into ra/err-query-over-l…
rallen090 4a65615
more exhaustive query metrics
rallen090 6dbbee8
Merge remote-tracking branch 'origin/master' into ra/err-query-over-l…
rallen090 c518cbb
reverting cost mock gen in query
rallen090 ec8aafd
mod fix
rallen090 a818509
mod fix 2
rallen090 d116b5d
mod fix 3
rallen090 9a1473e
rpc mock
rallen090 c82fa90
mod fix 5
rallen090 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think something like
FailOnLimitExceeded
is a bit more descriptive here?