Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Implemented the Graphite
delay
function #2567[query] Implemented the Graphite
delay
function #2567Changes from 33 commits
4e901d7
f42685a
f0df4ce
bef6377
8ce6dc3
30ef946
cf9288f
50b0ae9
1ebe629
ebaafce
2a0643c
cb088b2
2e183a5
dbe7b33
53222b9
8c2b6bf
01792e7
a1f7cad
2ea3fa8
29a032d
dba69f4
28799cb
117e24f
a3b7abb
a2ab5aa
5ff388b
b9a5ecc
09ed1ce
9e70f82
9be8bfa
99852b2
0184b23
ad6fc10
f5e30d3
1d54439
c545823
d20b425
5aa39ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Prefer to pre-allocate slice but use append for collecting values.
e.g.
We find using this wherever possible causes less bugs in general (i.e. if you have a continue that skips some entries in future in the middle of the loop, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change series to be
series *ts.Series
so that it doesn't have to be dereferenced when called? Don't seem to need a reason to dereference the type instead of just passing the ref directly.nit: Remove the extra space here
steps int )
should besteps int)
.also nit: Should be just
ts.Values
not(ts.Values)
since it's single return type.