Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coordinator] Pass along instrument options into custom rule store fn #3027

Merged
merged 1 commit into from
Dec 17, 2020
Merged

[coordinator] Pass along instrument options into custom rule store fn #3027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmd/services/m3coordinator/downsample/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ var (
)

// CustomRuleStoreFn is a function to swap the backend used for the rule stores.
type CustomRuleStoreFn func(clusterclient.Client) (kv.TxnStore, error)
type CustomRuleStoreFn func(clusterclient.Client, instrument.Options) (kv.TxnStore, error)

// DownsamplerOptions is a set of required downsampler options.
type DownsamplerOptions struct {
Expand Down
2 changes: 1 addition & 1 deletion src/query/server/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ func newDownsampler(
"cluster management config client")
}
} else {
kvStore, err = applyCustomRuleStore(clusterManagementClient)
kvStore, err = applyCustomRuleStore(clusterManagementClient, instrumentOpts)
if err != nil {
return nil, errors.Wrap(err, "unable to apply custom rule store")
}
Expand Down