[query] Take bounds into account for list endpoints #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyk
approved these changes
Jan 21, 2021
| } | ||
|
|
||
| if start.After(end) { | ||
| err := fmt.Errorf("start %v must be after end %v", start, end) |
| // ParseStartAndEnd parses start and end params from the request. | ||
| func ParseStartAndEnd( | ||
| r *http.Request, | ||
| parseOpts xpromql.ParseOptions, |
There was a problem hiding this comment.
why does this need the whole parseOpts instead of only the NowFn()?
There was a problem hiding this comment.
Figured this was cleaner than building a new parseOpts on each query; can go that route if preferred
| parseOpts xpromql.ParseOptions, | ||
| ) (time.Time, time.Time, error) { | ||
| if err := r.ParseForm(); err != nil { | ||
| return time.Time{}, time.Time{}, xerrors.NewInvalidParamsError(err) |
There was a problem hiding this comment.
will this propagate as a 400?
| @@ -123,7 +123,7 @@ func TestTagValues(t *testing.T) { | |||
| url := fmt.Sprintf("/label/{%s}/values", NameReplace) | |||
|
|
|||
| for _, tt := range names { | |||
| path := fmt.Sprintf("/label/%s/values", tt.name) | |||
| path := fmt.Sprintf("/label/%s/values?start=100", tt.name) | |||
There was a problem hiding this comment.
can we have a case with an end too?
Codecov Report
@@ Coverage Diff @@
## master #3110 +/- ##
=========================================
- Coverage 72.2% 72.2% -0.1%
=========================================
Files 1084 1084
Lines 100264 100188 -76
=========================================
- Hits 72484 72416 -68
+ Misses 22751 22734 -17
- Partials 5029 5038 +9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
soundvibe
added a commit
that referenced
this pull request
Jan 22, 2021
* master: [DOCS] Update to cluster docs (#3084) [dbnode][coordinator] Ensure docs limit is propagated for search and aggregate RPCs (#3108) [query] Take bounds into account for list endpoints (#3110) Add warning to changing blocksize (#3096) Add support for dynamic query limit overriding (#3090) [tests] test setups exported to allow us to use it from other packages (#3042) [query] Implemented Graphite's pow function (#3048) [dbnode] Direct conversion of encoded tags to doc.Metadata (#3087) [tests] Skip flaky TestWatchNoLeader (#3106) [dbnode] Faster search of tag bytes in convert.FromSeriesIDAndTags (#3075) Replace bytes.Compare() == 0 with bytes.Equal() (#3101) Capture seekerMgr instead Rlock (#3104) [m3db] Check bloom filter before stream request allocation (#3103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bounds parsing to
/api/v1/labelsand/api/v1/label/<label_name>/valuesendpoints