[query] Add determinism to Graphite sorting and reduce functions #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3164 +/- ##
=========================================
- Coverage 72.4% 40.1% -32.3%
=========================================
Files 1085 993 -92
Lines 101127 92688 -8439
=========================================
- Hits 73233 37190 -36043
- Misses 22839 51901 +29062
+ Partials 5055 3597 -1458
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
yyin-sc
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the Graphite sorting and reduce functions to be deterministic if there is multiple ranked series at the same sort order. This is done by using sort.Stable and if there was no incoming sort order into the function then applying sort by name to have determinism on which sort.Stable will pick as results.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: