[query] Fix Graphite nil arg not interpreted as explicit nil for asPercent #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyin-sc
approved these changes
May 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #3481 +/- ##
======================================
Coverage 55.8% 55.9%
======================================
Files 548 548
Lines 61188 61188
======================================
+ Hits 34167 34218 +51
+ Misses 23924 23881 -43
+ Partials 3097 3089 -8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
linasm
approved these changes
May 7, 2021
soundvibe
added a commit
that referenced
this pull request
May 10, 2021
* master: [query] Add Graphite movingWindow() function (#3484) [lint] Add missing build tags to linter configuration (#3480) [query] Fix Graphite nil arg not interpreted as explicit nil (#3481) [query] Fix Graphite context time window expansions not being cumulative [readme] Remove coverage badge due to CodeCov not able to execute (#3476) [query] Fix using median with aggregateWithWildcards and support more aggregate functions (#3469) [matcher] [coordinator] Add RequireNamespaceWatchOnInit option (#3468) [buildkite] Remove codecov uploading from unit tests (#3475) [aggregator] Add integration test for aggregator placement changes (#3465) [tools] Use streaming reads in read_data_files (#3474) [tools] Close the reader in read_data_files (#3473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
By default Graphite uses
nilto mean take the sum of the numerator as the denominator. Using an empty list as the default value for the total arg causes it not to be interpreted as explicitniland instead for it to treat it as an empty fetch expression that fetched no series which then causes an error (which is correct if you fetched no series, but in this case the correct behavior is to use the sum of the numerator as the denominator).This also fixes Graphite function execution to allow passing explicit nil as arguments since before it would cause issues unwrapping the nil without checking during function call execution.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: