[dbnode] Add ability to force repair regardless namespace has option set and add compare only repair type #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set and allow compare only repair type
robskillington
changed the title
arnikola
approved these changes
Jun 9, 2021
| // Type is the type of repair to run. | ||
| Type repair.Type `yaml:"type"` | ||
|
|
||
| // Force the repair to run regardless of whether namespaces have repair enabled or not. |
There was a problem hiding this comment.
nit: change to ForceEnabled for context?
| var successCounters []tally.CounterSnapshot | ||
| for _, setup := range setups { | ||
| scope := setup.Scope() | ||
| for _, v := range scope.Snapshot().Counters() { |
There was a problem hiding this comment.
nit: can also use tallytest.AssertCounterValue but it can be a little finicky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds ability to force repair regardless of if a namespace has repair option set or not. Also adds the ability to simply run comparison and emit metrics instead of executing the repair of the data, useful for assessing health of the cluster without automatic background repairs running.
Also adds an integration test that verifies the flags are respected between the different components in the storage package.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: