Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix graphite summarize/summarize to add missing agg functions #3583

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

yyin-sc
Copy link
Collaborator

@yyin-sc yyin-sc commented Jul 2, 2021

What this PR does / why we need it:

Fixes graphite summarize/summarize to add missing agg functions, including

  1. median
  2. diff
  3. range
  4. stddev
  5. Multiply
  6. count

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3583 (0bbc8db) into master (c35fa2d) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3583   +/-   ##
======================================
  Coverage    55.9%   55.9%           
======================================
  Files         551     551           
  Lines       61832   61832           
======================================
+ Hits        34578   34598   +20     
+ Misses      24134   24122   -12     
+ Partials     3120    3112    -8     
Flag Coverage Δ
aggregator 57.2% <ø> (ø)
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.4% <ø> (+<0.1%) ⬆️
m3em 46.4% <ø> (ø)
metrics 19.7% <ø> (ø)
msg 74.1% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35fa2d...0bbc8db. Read the comment docs.

@@ -193,63 +181,3 @@ func sumSpecificationFunc(series ts.SeriesList) string {
func averageSpecificationFunc(series ts.SeriesList) string {
return wrapPathExpr("averageSeries", series)
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can remove all this too:

// specificationFunc determines the output series specification given a series list.
type specificationFunc func(ts.SeriesList) string
func sumSpecificationFunc(series ts.SeriesList) string {
	return wrapPathExpr("sumSeries", series)
}
func averageSpecificationFunc(series ts.SeriesList) string {
	return wrapPathExpr("averageSeries", series)
}

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit aa932d9 into m3db:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants