-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Add Graphite find integration test that verifies complex trees return valid results #3636
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3636 +/- ##
========================================
- Coverage 57.3% 56.3% -1.1%
========================================
Files 551 551
Lines 62978 61868 -1110
========================================
- Hits 36137 34872 -1265
- Misses 23648 23879 +231
+ Partials 3193 3117 -76
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with #3639 being one possible way to make the test green.
501933c
to
b5bb88d
Compare
…s return valid results
…thousands of series entries
…condition unknown
ad7b27d
to
d55db2c
Compare
What this PR does / why we need it:
Previously we only had quite basic coverage of simple cases with the
carbon
docker integration tests for the find API (see https://github.com/m3db/m3/tree/v1.1.0/scripts/docker-integration-tests/carbon).This adds a much more comprehensive and complex integration test that tests a complex tree and verifies all results in the tree are correctly returned when walking the tree and issuing queries.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: