Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Add Graphite find integration test that verifies complex trees return valid results #3636

Merged
merged 19 commits into from
Jun 8, 2022

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Previously we only had quite basic coverage of simple cases with the carbon docker integration tests for the find API (see https://github.com/m3db/m3/tree/v1.1.0/scripts/docker-integration-tests/carbon).

This adds a much more comprehensive and complex integration test that tests a complex tree and verifies all results in the tree are correctly returned when walking the tree and issuing queries.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #3636 (29722e7) into master (ddcfc1f) will decrease coverage by 1.0%.
The diff coverage is n/a.

❗ Current head 29722e7 differs from pull request most recent head d55db2c. Consider uploading reports for the commit d55db2c to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3636     +/-   ##
========================================
- Coverage    57.3%   56.3%   -1.1%     
========================================
  Files         551     551             
  Lines       62978   61868   -1110     
========================================
- Hits        36137   34872   -1265     
- Misses      23648   23879    +231     
+ Partials     3193    3117     -76     
Flag Coverage Δ
aggregator 57.1% <0.0%> (-5.6%) ⬇️
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (?)
dbnode 60.9% <0.0%> (-0.5%) ⬇️
m3em 46.4% <0.0%> (ø)
metrics 19.8% <0.0%> (+0.1%) ⬆️
msg 74.5% <0.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcfc1f...d55db2c. Read the comment docs.

Copy link
Collaborator

@linasm linasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with #3639 being one possible way to make the test green.

@robskillington robskillington force-pushed the r/graphite-find-integration-test branch from 501933c to b5bb88d Compare May 31, 2022 20:55
@robskillington robskillington force-pushed the r/graphite-find-integration-test branch from ad7b27d to d55db2c Compare June 8, 2022 18:09
@robskillington robskillington enabled auto-merge (squash) June 8, 2022 18:09
@robskillington robskillington merged commit f9379ea into master Jun 8, 2022
@robskillington robskillington deleted the r/graphite-find-integration-test branch June 8, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants