Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] More struct alignment fixes #3908

Merged
merged 1 commit into from
Nov 8, 2021
Merged

[aggregator] More struct alignment fixes #3908

merged 1 commit into from
Nov 8, 2021

Conversation

vdarulis
Copy link
Collaborator

@vdarulis vdarulis commented Nov 6, 2021

What this PR does / why we need it:

Rearrange a few more common structs to reduce gc scan/memory overhead, based on fieldalignment tool

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #3908 (dc53a6b) into master (08209d4) will increase coverage by 0.0%.
The diff coverage is 83.3%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3908   +/-   ##
======================================
  Coverage    56.6%   56.6%           
======================================
  Files         553     553           
  Lines       63278   63278           
======================================
+ Hits        35836   35849   +13     
+ Misses      24241   24235    -6     
+ Partials     3201    3194    -7     
Flag Coverage Δ
aggregator 62.3% <83.3%> (+<0.1%) ⬆️
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.3% <ø> (+<0.1%) ⬆️
m3em 46.4% <ø> (ø)
metrics 19.7% <ø> (ø)
msg 74.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08209d4...dc53a6b. Read the comment docs.

Copy link
Collaborator

@ryanhall07 ryanhall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! will be interested to see how this helps with heap/gc

@vdarulis
Copy link
Collaborator Author

vdarulis commented Nov 8, 2021

thanks! will be interested to see how this helps with heap/gc

It's usually minor, but since every aggregation/entry/etc. overhead is static per-metric, shaving 8-32 bytes here and there helps - last pass (on aggregator.Entry et al) did drop mem usage by ~3-4% iirc.

@vdarulis vdarulis merged commit 513748e into master Nov 8, 2021
@vdarulis vdarulis deleted the v/agg_mem branch November 8, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants