Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coord] Guard against duplicate __rollup__ tags #3950

Merged
merged 4 commits into from
Dec 1, 2021
Merged

[coord] Guard against duplicate __rollup__ tags #3950

merged 4 commits into from
Dec 1, 2021

Commits on Nov 30, 2021

  1. [coord] Guard against duplicate __rollup__ tags 

    Previously the tag merge logic could result in duplicate __rollup__ tags
if the provided tags already had __rollup__.

Additionally refactored to lazily merge the 2 sorted slices when calling
Next(). This made it much easier to add deduping logic and I believe
makes it easier to follow the code.
    @ryanhall07
    ryanhall07 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    da75b53 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. fix tests

    @ryanhall07
    ryanhall07 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    aeb82ea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rhall-dup-rollup-take2

    @ryanhall07
    ryanhall07 authored Dec 1, 2021
    Configuration menu
    Copy the full SHA
    479954f View commit details
    Browse the repository at this point in the history

  3. lint

    @ryanhall07
    ryanhall07 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    90325dd View commit details
    Browse the repository at this point in the history